Make prettier handle closing tags better #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Jul 14, 2023
| @@ -58,9 +58,13 @@ | |||
| <CollapsibleCard label="Help"> | |||
| <ul> | |||
| <li> | |||
| <b>Click</b> on the map to open a new tab with a 3rd-party imagery provider | |||
| <b>Click</b> | |||
| on the map to open a new tab with a 3rd-party imagery provider | |||
There was a problem hiding this comment.
Hmm, this is a little worse IMO, but worth the improvement for buttons
Pete-Y-CS
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is much easier to read this way, personally.
See https://prettier.io/blog/2018/11/07/1.15.0.html#whitespace-sensitive-formatting. This can theoretically affect display. I'm combing through the changes in code / on-screen and don't spot any differences, so I think we're fine and this is worth it.