Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanical refactor to group imports from common and govuk directories #281

Merged
merged 1 commit into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/BaselayerSwitcher.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import Select from "./govuk/Select.svelte";
import { Select } from "./govuk";

// TODO Be specific about "streets" | "hybrid", but then we need actual error
// handling when we parse it from URL params
Expand Down
2 changes: 1 addition & 1 deletion src/lib/Legend.svelte
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script lang="ts">
import { colors } from "../colors";
import type { Schema } from "../types";
import CollapsibleCard from "./common/CollapsibleCard.svelte";
import { CollapsibleCard } from "./common";

export let schema: Schema;
</script>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/ZoomOutMap.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import icon from "../../assets/zoom_out_map.svg";
import { bbox } from "../maplibre_helpers";
import { map } from "../stores";
import SecondaryButton from "./govuk/SecondaryButton.svelte";
import { SecondaryButton } from "./govuk";

export let boundaryGeojson: GeoJSON;

Expand Down
6 changes: 2 additions & 4 deletions src/lib/browse/Filters.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@
import { onMount } from "svelte";
import { gjScheme } from "../../stores";
import type { FeatureUnion } from "../../types";
import CollapsibleCard from "../common/CollapsibleCard.svelte";
import FormElement from "../govuk/FormElement.svelte";
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import Select from "../govuk/Select.svelte";
import { CollapsibleCard } from "../common";
import { FormElement, SecondaryButton, Select } from "../govuk";
import { type Scheme } from "./data";

// These are immutable; re-create this component if they change
Expand Down
4 changes: 2 additions & 2 deletions src/lib/browse/SchemeCard.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import type { FeatureCollection } from "geojson";
import { bbox } from "../../maplibre_helpers";
import { gjScheme, map } from "../../stores";
import CollapsibleCard from "../common/CollapsibleCard.svelte";
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import { CollapsibleCard } from "../common";
import { SecondaryButton } from "../govuk";
import type { Scheme } from "./data";

export let scheme: Scheme;
Expand Down
3 changes: 1 addition & 2 deletions src/lib/common/ConfirmationModal.svelte
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<script lang="ts">
import { createEventDispatcher } from "svelte";
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import WarningButton from "../govuk/WarningButton.svelte";
import { SecondaryButton, WarningButton } from "../govuk";
import Modal from "./Modal.svelte";

const dispatch = createEventDispatcher();
Expand Down
2 changes: 1 addition & 1 deletion src/lib/common/FileInput.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import FormElement from "../govuk/FormElement.svelte";
import { FormElement } from "../govuk";

export let label: string;
// This must be unique in the page
Expand Down
2 changes: 1 addition & 1 deletion src/lib/common/Modal.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import { SecondaryButton } from "../govuk";

export let title: string;
export let open = false;
Expand Down
9 changes: 9 additions & 0 deletions src/lib/common/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export { default as CollapsibleCard } from "./CollapsibleCard.svelte";
export { default as ConfirmationModal } from "./ConfirmationModal.svelte";
export { default as DiscreteLegend } from "./DiscreteLegend.svelte";
export { default as ExternalLink } from "./ExternalLink.svelte";
export { default as FileInput } from "./FileInput.svelte";
export { default as HelpIcon } from "./HelpIcon.svelte";
export { default as Layout } from "./Layout.svelte";
export { default as MapTooltips } from "./MapTooltips.svelte";
export { default as Modal } from "./Modal.svelte";
4 changes: 2 additions & 2 deletions src/lib/draw/StreetViewMode.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import type { MapMouseEvent } from "maplibre-gl";
import { currentMode, map, userSettings } from "../../stores";
import type { Mode } from "../../types";
import CollapsibleCard from "../common/CollapsibleCard.svelte";
import Radio from "../govuk/Radio.svelte";
import { CollapsibleCard } from "../common";
import { Radio } from "../govuk";
import type { EventHandler } from "./event_handler";

export let eventHandler: EventHandler;
Expand Down
4 changes: 2 additions & 2 deletions src/lib/draw/point/PointControls.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import CollapsibleCard from "../../common/CollapsibleCard.svelte";
import SecondaryButton from "../../govuk/SecondaryButton.svelte";
import { CollapsibleCard } from "../../common";
import { SecondaryButton } from "../../govuk";
import { PointTool } from "./point_tool";

export let pointTool: PointTool;
Expand Down
5 changes: 2 additions & 3 deletions src/lib/draw/polygon/PolygonControls.svelte
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<script lang="ts">
import CollapsibleCard from "../../common/CollapsibleCard.svelte";
import DefaultButton from "../../govuk/DefaultButton.svelte";
import SecondaryButton from "../../govuk/SecondaryButton.svelte";
import { CollapsibleCard } from "../../common";
import { DefaultButton, SecondaryButton } from "../../govuk";
import { PolygonTool } from "./polygon_tool";

export let polygonTool: PolygonTool;
Expand Down
12 changes: 7 additions & 5 deletions src/lib/draw/route/RouteControls.svelte
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
<script lang="ts">
import { userSettings } from "../../../stores";
import CollapsibleCard from "../../common/CollapsibleCard.svelte";
import Checkbox from "../../govuk/Checkbox.svelte";
import CheckboxGroup from "../../govuk/CheckboxGroup.svelte";
import DefaultButton from "../../govuk/DefaultButton.svelte";
import SecondaryButton from "../../govuk/SecondaryButton.svelte";
import { CollapsibleCard } from "../../common";
import {
Checkbox,
CheckboxGroup,
DefaultButton,
SecondaryButton,
} from "../../govuk";
import { RouteTool } from "./route_tool";

export let routeTool: RouteTool;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/draw/route/SplitRouteMode.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
} from "../../../maplibre_helpers";
import { currentMode, gjScheme, map, newFeatureId } from "../../../stores";
import type { Mode, Feature as OurFeature } from "../../../types";
import CollapsibleCard from "../../common/CollapsibleCard.svelte";
import { CollapsibleCard } from "../../common";
import type { EventHandler } from "../event_handler";

const thisMode = "split-route";
Expand Down
5 changes: 2 additions & 3 deletions src/lib/draw/snap_polygon/SnapPolygonControls.svelte
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<script lang="ts">
import CollapsibleCard from "../../common/CollapsibleCard.svelte";
import DefaultButton from "../../govuk/DefaultButton.svelte";
import SecondaryButton from "../../govuk/SecondaryButton.svelte";
import { CollapsibleCard } from "../../common";
import { DefaultButton, SecondaryButton } from "../../govuk";
import { RouteTool } from "../route/route_tool";

export let routeTool: RouteTool;
Expand Down
5 changes: 1 addition & 4 deletions src/lib/forms/FormV1.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
import type { Feature, LineString } from "geojson";
import { prettyPrintMeters } from "../../maplibre_helpers";
import { gjScheme, routeInfo } from "../../stores";
import FormElement from "../govuk/FormElement.svelte";
import Radio from "../govuk/Radio.svelte";
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import TextArea from "../govuk/TextArea.svelte";
import { FormElement, Radio, SecondaryButton, TextArea } from "../govuk";
import RouteInfoLayers from "./RouteInfoLayers.svelte";

export let id: number;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/forms/RouteInfoLayers.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import { routeInfo } from "../../stores";
import Select from "../govuk/Select.svelte";
import { Select } from "../govuk";
import LaneDetails from "../layers/LaneDetails.svelte";
import SpeedLimits from "../layers/SpeedLimits.svelte";

Expand Down
2 changes: 1 addition & 1 deletion src/lib/govuk/Select.svelte
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script lang="ts">
import FormElement from "../govuk/FormElement.svelte";
import { FormElement } from "../govuk";

export let label: string;
// A unique (per page) ID
Expand Down
11 changes: 11 additions & 0 deletions src/lib/govuk/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
export { default as CheckboxGroup } from "./CheckboxGroup.svelte";
export { default as Checkbox } from "./Checkbox.svelte";
export { default as DefaultButton } from "./DefaultButton.svelte";
export { default as ErrorMessage } from "./ErrorMessage.svelte";
export { default as FormElement } from "./FormElement.svelte";
export { default as Radio } from "./Radio.svelte";
export { default as SecondaryButton } from "./SecondaryButton.svelte";
export { default as Select } from "./Select.svelte";
export { default as TextArea } from "./TextArea.svelte";
export { default as TextInput } from "./TextInput.svelte";
export { default as WarningButton } from "./WarningButton.svelte";
2 changes: 1 addition & 1 deletion src/lib/layers/ContextualLayers.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import { formOpen, routeInfo } from "../../stores";
import Select from "../govuk/Select.svelte";
import { Select } from "../govuk";
import SpeedLimits from "./SpeedLimits.svelte";

let show: "none" | "speed limits" = "none";
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layers/LaneDetails.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import { onMount } from "svelte";
import { gjScheme, routeInfo } from "../../stores";
import type { Feature } from "../../types";
import HelpIcon from "../common/HelpIcon.svelte";
import { HelpIcon } from "../common";
import IntersectionMarkings from "./lane_details/IntersectionMarkings.svelte";
import IntersectionPolygons from "./lane_details/IntersectionPolygons.svelte";
import LaneMarkings from "./lane_details/LaneMarkings.svelte";
Expand Down
4 changes: 1 addition & 3 deletions src/lib/layers/SpeedLimits.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
} from "../../maplibre_helpers";
import { gjScheme, map, routeInfo } from "../../stores";
import type { Feature } from "../../types";
import DiscreteLegend from "../common/DiscreteLegend.svelte";
import HelpIcon from "../common/HelpIcon.svelte";
import MapTooltips from "../common/MapTooltips.svelte";
import { DiscreteLegend, HelpIcon, MapTooltips } from "../common";

// Show along a route if specified, or show all otherwise
export let id: number | undefined;
Expand Down
3 changes: 1 addition & 2 deletions src/lib/sidebar/About.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script lang="ts">
import ExternalLink from "../common/ExternalLink.svelte";
import Modal from "../common/Modal.svelte";
import { ExternalLink, Modal } from "../common";

export let open: boolean;
</script>
Expand Down
13 changes: 7 additions & 6 deletions src/lib/sidebar/EntireScheme.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@
sidebarHover,
} from "../../stores";
import { schemaPluralNoun, type Schema, type Scheme } from "../../types";
import ConfirmationModal from "../common/ConfirmationModal.svelte";
import FileInput from "../common/FileInput.svelte";
import ErrorMessage from "../govuk/ErrorMessage.svelte";
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import TextInput from "../govuk/TextInput.svelte";
import WarningButton from "../govuk/WarningButton.svelte";
import { ConfirmationModal, FileInput } from "../common";
import {
ErrorMessage,
SecondaryButton,
TextInput,
WarningButton,
} from "../govuk";

export let authorityName: string;
export let schema: Schema;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/sidebar/Instructions.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import { schemaPluralNoun, type Schema } from "../../types";
import Modal from "../common/Modal.svelte";
import { Modal } from "../common";

export let open: boolean;
export let schema: Schema;
Expand Down
3 changes: 1 addition & 2 deletions src/lib/sidebar/InterventionList.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
import FormV1 from "../forms/FormV1.svelte";
import FormV2 from "../forms/FormV2.svelte";
import PlanningForm from "../forms/PlanningForm.svelte";
import SecondaryButton from "../govuk/SecondaryButton.svelte";
import WarningButton from "../govuk/WarningButton.svelte";
import { SecondaryButton, WarningButton } from "../govuk";
import AccordionItem from "./AccordionItem.svelte";

export let schema: Schema;
Expand Down
4 changes: 2 additions & 2 deletions src/pages/App.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
import authoritiesUrl from "../../assets/authorities.geojson?url";
import BaselayerSwitcher from "../lib/BaselayerSwitcher.svelte";
import BoundaryLayer from "../lib/BoundaryLayer.svelte";
import Layout from "../lib/common/Layout.svelte";
import { Layout } from "../lib/common";
import HoverLayer from "../lib/draw/HoverLayer.svelte";
import InterventionLayer from "../lib/draw/InterventionLayer.svelte";
import Toolbox from "../lib/draw/Toolbox.svelte";
import SecondaryButton from "../lib/govuk/SecondaryButton.svelte";
import { SecondaryButton } from "../lib/govuk";
import ContextualLayers from "../lib/layers/ContextualLayers.svelte";
import Legend from "../lib/Legend.svelte";
import Map from "../lib/Map.svelte";
Expand Down
7 changes: 2 additions & 5 deletions src/pages/BrowseSchemes.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@
import { processInput, type Scheme } from "../lib/browse/data";
import Filters from "../lib/browse/Filters.svelte";
import SchemeCard from "../lib/browse/SchemeCard.svelte";
import FileInput from "../lib/common/FileInput.svelte";
import Layout from "../lib/common/Layout.svelte";
import MapTooltips from "../lib/common/MapTooltips.svelte";
import { FileInput, Layout, MapTooltips } from "../lib/common";
import InterventionLayer from "../lib/draw/InterventionLayer.svelte";
import ErrorMessage from "../lib/govuk/ErrorMessage.svelte";
import SecondaryButton from "../lib/govuk/SecondaryButton.svelte";
import { ErrorMessage, SecondaryButton } from "../lib/govuk";
import Legend from "../lib/Legend.svelte";
import MapLibreMap from "../lib/Map.svelte";
import ZoomOutMap from "../lib/ZoomOutMap.svelte";
Expand Down
14 changes: 8 additions & 6 deletions src/pages/ChooseArea.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@
import { initAll } from "govuk-frontend";
import { Map } from "maplibre-gl";
import { onMount } from "svelte";
import DefaultButton from "../lib/govuk/DefaultButton.svelte";
import ErrorMessage from "../lib/govuk/ErrorMessage.svelte";
import FormElement from "../lib/govuk/FormElement.svelte";
import Radio from "../lib/govuk/Radio.svelte";
import SecondaryButton from "../lib/govuk/SecondaryButton.svelte";
import {
DefaultButton,
ErrorMessage,
FormElement,
Radio,
SecondaryButton,
} from "../lib/govuk";
import "maplibre-gl/dist/maplibre-gl.css";
import { FileInput } from "../lib/common";
import { getAuthoritiesGeoJson } from "../lib/common/data_getter";
import FileInput from "../lib/common/FileInput.svelte";
import About from "../lib/sidebar/About.svelte";
import { bbox } from "../maplibre_helpers";
import type { Schema } from "../types";
Expand Down
Loading