-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer with wards, LADs, and CAs. #285 #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX problems when there are multiple boundaries turned on, but we need to know how people want to use this before figuring out a fix. (Like only allowing one boundary layer at a time)
@@ -62,6 +62,7 @@ | |||
let name = e.detail.properties.Name; | |||
name = name.replace(/ Boro Const$/, ""); | |||
name = name.replace(/ Co Const$/, ""); | |||
name = encodeURIComponent(name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be paranoid about "&" and things
|
||
function onClick(e: CustomEvent<MapGeoJSONFeature>) { | ||
let name = encodeURIComponent(e.detail.properties.name); | ||
// Help people find the councillor for this area |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not do any better than Google this time :(
@@ -4,6 +4,7 @@ export const colors = { | |||
hospitals: "#B73D25", | |||
mrn: "#006478", | |||
parliamentary_constituencies: "#006E59", | |||
wards: "purple", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to just making these up. We need a principled way of doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're also gonna run out of significantly distinct colours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could maybe make all the boundary layers one color, and effectively change this to a radio button. But I'm not sure -- we need to know how people want to use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I also imagined we could have a set of colours which got applied to things as you ticked em, and you are only allowed a certain number of layers at once. A changing legend does sound like bad UX though so probably not a good idea
Broader thought probably already discussed but just while in my head: easy to add these layers to the scheme editing and other pages at some point in the future? |
From a technical perspective, yes, but not a priority right now. There are UX challenges with how multiple layers overlap with scheme data, and they're more complicated with sketch tools. We can look into it later when it's needed. |
Also includes CAs and LADs now: screencast.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I think we've discussed, a lot of these controls share stuff in common, maybe we should log an issue to tidy them up once we've created all the layers that exist and we can think clearly about what can be shared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, 100% agree. I think we need a few more first to understand commonalities. The census ones are turning out to be special in a few ways...
Thanks to Alex for pointing us to the data source! The import is in acteng/atip-data-prep#17.
Demo: https://acteng.github.io/atip/wards/browse.html