Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an IMD layer #309

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add an IMD layer #309

merged 1 commit into from
Aug 14, 2023

Conversation

dabreegster
Copy link
Contributor

screencast.mp4

https://acteng.github.io/atip/imd/browse.html

Hopefully a pretty straightforward one. I sanity checked compared ranks to http://dclgapps.communities.gov.uk/imd/iod_index.html.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any useful reference to open for clicking; http://dclgapps.communities.gov.uk/imd/iod_index.html doesn't have URL controls

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might be valuable to still send the user through to that page, even if we can't send them to the specific LSOA info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's listed in the help popup. Feels unintuitive to make a click on a specific LSOA in the map have the same effect everywhere

@@ -179,6 +180,7 @@
</CollapsibleCard>
<CollapsibleCard label="Census">
<CensusOutputAreaLayerControl />
<ImdLayerControl />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to one of three OA-level census layers alongside the IMD layer. This is awkward, but I don't know how to solve it (UX-wise) yet. I think we only ever want one boundary/census/"covers everything" layer on at a time, and not sure how to communicate that as radio buttons across categories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I don't know how to communicate it, and it's worth checking with users first, but making these and boundaries all mutually exclusive sounds like a good future task

@dabreegster dabreegster merged commit 87b3323 into main Aug 14, 2023
2 checks passed
@dabreegster dabreegster deleted the imd branch August 14, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants