-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a layer for existing cycle paths. #299 #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screencast.mp4
}, | ||
"red" | ||
), | ||
width: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted from https://github.com/bdon/HighRoadPlus/blob/main/highroadplus.js. Keeping lines the same thickness at all zoom levels doesn't make sense, because it's hard to click things when zoomed in, and at low zoom, things overlap badly. I fiddled with this only a little bit to make it look OK, happy for suggestions.
More generally, hovering/tooltips/clicking at low zoom levels for many of our layers isn't really appropriate. Need to revisit more generally
</p> | ||
<ul> | ||
<li> | ||
<b>Separated tracks</b> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely someone outside our team needs to review the wording choices here
// Draw most things beneath text road labels. This is the only layer in this | ||
// list generated by the MapTiler basemap we use. | ||
// Draw most things beneath text road labels. These IDs come from the | ||
// MapTiler basemap, and there are different ones for each basemap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed when we switched to the new dataviz style, labels got incorrectly buried. Fixing that here
Sounds really promising. Taking a look! |
Overall: big 👍 |
Demo: https://acteng.github.io/atip/cycle_path_layer/browse.html
See issue for big TODOs and reference maps.