Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework to use maplibre helpers as library #314

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

Pete-Y-CS
Copy link
Contributor

Easier to open a new PR and close the old one, if you prefer this we can use this, tests passed locally

@@ -0,0 +1,96 @@
<script lang="ts">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this is here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong rebasing. If you just delete this file, I think we're good -- the one npm run check failure is a problem here

Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good to go after:

  1. Removing the stray Imd file that somehow appeared
  2. npm run fmt (some import orders changed for me locally)

@@ -0,0 +1,96 @@
<script lang="ts">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something went wrong rebasing. If you just delete this file, I think we're good -- the one npm run check failure is a problem here

@@ -0,0 +1 @@
export * from "./utils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good, this did work

@Pete-Y-CS Pete-Y-CS changed the title Rewrk to use maplibre helpers as library Rework to use maplibre helpers as library Aug 17, 2023
@Pete-Y-CS Pete-Y-CS merged commit 2a9e93d into main Aug 17, 2023
2 checks passed
@Pete-Y-CS Pete-Y-CS deleted the rerefactor-maplibre branch August 17, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants