-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework to use maplibre helpers as library #314
Conversation
@@ -0,0 +1,96 @@ | |||
<script lang="ts"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something went wrong rebasing. If you just delete this file, I think we're good -- the one npm run check failure is a problem here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Good to go after:
- Removing the stray Imd file that somehow appeared
- npm run fmt (some import orders changed for me locally)
@@ -0,0 +1,96 @@ | |||
<script lang="ts"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something went wrong rebasing. If you just delete this file, I think we're good -- the one npm run check failure is a problem here
@@ -0,0 +1 @@ | |||
export * from "./utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good, this did work
a1f2c83
to
171bde6
Compare
171bde6
to
bf803bb
Compare
Easier to open a new PR and close the old one, if you prefer this we can use this, tests passed locally