Stop using relative module imports #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks amazing! Will have a quick look locally but I don't see why it would be an issue! Sure I can make VSCode work with it |
|
Yup gave it a quick test drive! Fire at will! |
dabreegster
force-pushed
the
import_abs_paths
branch
from
fac6485
to
3f3ea21
Compare
|
Alright, used pretty much everywhere, except in a few cases for "package private" stuff. Manual testing shows no behavioral diff. Once playwright tests pass, I'll merge. As a future followup, I'd like to consider moving most things in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yongrenjie pointed me at this awesome trick, which'll let us stop using relative paths for imports and instead treat
src/as our root. This would make changing directory structure way easier. Pete, if this sample change looks good and it works in your IDE, I'll make it everywhere!