Show the version of the app #340
Conversation
src/lib/browse/AppVersion.svelte
Outdated
| version = "Local development"; | ||
| } else if (window.location.hostname == "acteng.github.io") { | ||
| if (window.location.pathname == "/atip/browse.html") { | ||
| version = "Current development (public)"; |
There was a problem hiding this comment.
Better terms/names welcome
There was a problem hiding this comment.
Currently it's like this, I think "Current" is a bit redundant, will have a think.
There was a problem hiding this comment.
| version = "Current development (public)"; | |
| version = "Public (development)"; |
The Public is more important than dev/release and more widely understood. Plus shortens it. Public (release), Private (development) and Private (release) seem like reasonable options to me.
There was a problem hiding this comment.
Thanks! Updated the names in 88cad1a
| @@ -2,6 +2,7 @@ | |||
| // @ts-ignore no declarations | |||
| import { initAll } from "govuk-frontend"; | |||
| import "../style/main.css"; | |||
| import AppVersion from "lib/browse/AppVersion.svelte"; | |||
There was a problem hiding this comment.
Should this be on all the pages? I know what we currently have is specific to browse schemes but it feels like we might want something similar in other places?
There was a problem hiding this comment.
PTAL -- changed a few things about detecting the environment, mentioning it on multiple pages, etc
dabreegster
force-pushed
the
browse_about
branch
from
53a0176
to
021b953
Compare
Now that we have more deployment environments, make it clear where we are. Also provide some warnings and contact emails.