-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the version of the app #340
Conversation
src/lib/browse/AppVersion.svelte
Outdated
version = "Local development"; | ||
} else if (window.location.hostname == "acteng.github.io") { | ||
if (window.location.pathname == "/atip/browse.html") { | ||
version = "Current development (public)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better terms/names welcome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it's like this, I think "Current" is a bit redundant, will have a think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "Current development (public)"; | |
version = "Public (development)"; |
The Public is more important than dev/release and more widely understood. Plus shortens it. Public (release), Private (development) and Private (release) seem like reasonable options to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated the names in 88cad1a
@@ -2,6 +2,7 @@ | |||
// @ts-ignore no declarations | |||
import { initAll } from "govuk-frontend"; | |||
import "../style/main.css"; | |||
import AppVersion from "lib/browse/AppVersion.svelte"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be on all the pages? I know what we currently have is specific to browse schemes but it feels like we might want something similar in other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL -- changed a few things about detecting the environment, mentioning it on multiple pages, etc
53a0176
to
021b953
Compare
Now that we have more deployment environments, make it clear where we are. Also provide some warnings and contact emails.