Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename old deploy files and add public dev deploy workflow #528

Merged
merged 2 commits into from
Oct 22, 2024
Merged

rename old deploy files and add public dev deploy workflow #528

merged 2 commits into from
Oct 22, 2024

Conversation

Pete-Y-CS
Copy link
Contributor

No description provided.

@Pete-Y-CS
Copy link
Contributor Author

Service request that I think should allow us to deploy has been fulfilled

dabreegster
dabreegster approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's other steps in backend/README to fill out the GCS buckets and point to them, but guessing that's coming later

@Pete-Y-CS
Copy link
Contributor Author

There's other steps in backend/README to fill out the GCS buckets and point to them, but guessing that's coming later

ahh good shout. Bucket won't be ready yet but I'll make sure we're using the right project number to deploy in the yaml file used

@Pete-Y-CS Pete-Y-CS merged commit fce1663 into main Oct 22, 2024
2 checks passed
@Pete-Y-CS Pete-Y-CS deleted the add-public-deploy-dev branch October 22, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabreegster dabreegster dabreegster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pete-Y-CS @dabreegster