Let scheme forms finalize

acteng · Oct 30, 2024 · 82ce8b7 · 82ce8b7
1 parent 5581050
commit 82ce8b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/lib/config.ts b/src/lib/config.ts
@@ -36,6 +36,9 @@ export interface Config<F, S> {
     }>
   >;
 
+  // This component will only be instantiated when the user opens the modal to
+  // edit the scheme, so it can rely on onDestroy to finalize any
+  // changes.
   editSchemeForm: null | ComponentType<
     SvelteComponent<{
       gjSchemes: Writable<Schemes<F, S>>;

diff --git a/src/lib/sidebar/PerSchemeControls.svelte b/src/lib/sidebar/PerSchemeControls.svelte
@@ -190,7 +190,13 @@
 {/if}
 
 <Modal title="Edit scheme" bind:open={showEditModal}>
-  <svelte:component this={cfg.editSchemeForm} {gjSchemes} {scheme_reference} />
+  {#if showEditModal}
+    <svelte:component
+      this={cfg.editSchemeForm}
+      {gjSchemes}
+      {scheme_reference}
+    />
+  {/if}
 
   <ButtonGroup>
     <DefaultButton on:click={() => (showEditModal = false)}>