GH-85: Upgrade GOV.UK Frontend to 5.4.0

package.json

@@ -21,7 +21,7 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "govuk-frontend": "~5.3.0",
+    "govuk-frontend": "~5.4.0",
     "govuk-one-login-service-header": "govuk-one-login/service-header#f9ce92e4e9f5a8c0311e77bce211520a785e4ebc"
   },
   "devDependencies": {

pyproject.toml

@@ -9,8 +9,8 @@ dependencies = [
     "dataclass-wizard~=0.22.0",
     "flask~=3.0.0",
     "flask-session[sqlalchemy]~=0.8.0",
-    "govuk-frontend-jinja~=3.0.0",
-    "govuk-frontend-wtf~=3.0.0",
+    "govuk-frontend-jinja~=3.1.0",
+    "govuk-frontend-wtf~=3.1.0",
     "gunicorn~=22.0.0",
     "inject~=5.2.0",
     "pg8000~=1.31.0",

tests/e2e/pages.py

@@ -138,8 +138,8 @@ def __init__(self, banner: Locator):
         self._heading = banner.get_by_role("paragraph")
 
     @property
-    def heading(self) -> str | None:
-        return self._heading.text_content()
+    def heading(self) -> str:
+        return (self._heading.text_content() or "").strip()
 
     @classmethod
     def for_important(cls, page: Page) -> NotificationBannerComponent:

tests/integration/pages.py

@@ -383,7 +383,7 @@ def __iter__(self) -> Iterator[str]:
 
 class NotificationBannerComponent:
     def __init__(self, banner: Tag):
-        self.heading = one(banner.select("p")).string
+        self.heading = (one(banner.select("p")).string or "").strip()
 
     @classmethod
     def for_important(cls, soup: BeautifulSoup) -> NotificationBannerComponent | None:

tests/integration/test_scheme_funding.py

@@ -293,7 +293,7 @@ def test_cannot_spend_to_date_when_error(
         assert (
             change_spend_to_date_page.form.amount.is_errored
             and change_spend_to_date_page.form.amount.error == "Error: Enter spend to date"
-            and change_spend_to_date_page.form.amount.value is None
+            and change_spend_to_date_page.form.amount.value == ""
         )
         actual_scheme = schemes.get(1)
         assert actual_scheme