Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Incorrect scheme for SmartHomeV1QueryResponse #406

Open
Shatungoo opened this issue Aug 25, 2020 · 0 comments
Open

Incorrect scheme for SmartHomeV1QueryResponse #406

Shatungoo opened this issue Aug 25, 2020 · 0 comments

Comments

@Shatungoo
Copy link

2 optional fields (errorCode and debugString) missed inside interface SmartHomeV1QueryResponse.

Scheme from google https://developers.google.com/assistant/smarthome/reference/intent/query#response_format
payload:

  • errorCode: String. Optional. An error code for the entire transaction—for auth failures and partner system unavailability. For individual device errors use the errorCode within the device object.
  • debugString: String. Optional. Detailed error which will never be presented to users but may be logged or used during development.
  • devices: Object. Map of devices. Each property has the following name and value:

Library(src/service/smarthome/api/v1.ts) doesn't contain errorCode and debugString into reposnce(it uses the same scheme as payload for SmartHomeV1QueryRequest)


export interface SmartHomeV1QueryPayload {
  devices: ApiClientObjectMap<any>
}

export interface SmartHomeV1QueryResponse {
  requestId: string,
  payload: SmartHomeV1QueryPayload
}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant