Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github runner application exit code is not propagated via launcher #2769

Open
mattem opened this issue Aug 15, 2023 · 0 comments · May be fixed by #3406
Open

Github runner application exit code is not propagated via launcher #2769

mattem opened this issue Aug 15, 2023 · 0 comments · May be fixed by #3406
Labels
bug Something isn't working keep Label can be added as soon as we are sure the work on the issue is necessary

Comments

@mattem
Copy link

mattem commented Aug 15, 2023

Describe the bug
The wrapper script for Runner.Listener does not propagate the exit code when invoked, and always exists 0.
This makes it impossible for any systemd unit error handling to correctly handle the runner exit status.

Submitted a fix here, #2719 but it has not had any attention in over three weeks.

To Reproduce
Steps to reproduce the behavior:

  1. Force the runner listener process to exit non-zero (I did this via an invalid registration)
  2. Allow any retries to exhaust.
  3. Check the exit code of the process, note that it is 0.

Expected behavior
The error code is propagated to the caller.

Runner Version and Platform

Version of your runner?
v2.308.0

OS of the machine running the runner? OSX/Windows/Linux/...
Linux

What's not working?

N/A

Job Log Output

N/A

Runner and Worker's Diagnostic Logs

N/A
@mattem mattem added the bug Something isn't working label Aug 15, 2023
@nikola-jokic nikola-jokic added the keep Label can be added as soon as we are sure the work on the issue is necessary label Aug 18, 2023
jenseng added a commit to jenseng/runner that referenced this issue Jul 26, 2024
@jenseng
Standardize and fix exit code handling
3f4c8bb 
- Propagate non-zero exit codes up through run.sh/run.cmd/runsvc.sh
- Ensure .cmd scripts use 2 for retries (as was done for .sh in actions#1708)

Fixes actions#2769
Supersedes actions#2719
@jenseng jenseng linked a pull request Jul 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working keep Label can be added as soon as we are sure the work on the issue is necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize and fix exit code handling jenseng/runner
2 participants
@mattem @nikola-jokic