Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(node): add support for Node18, drop Node12, update Node16 #2257

Closed
wants to merge 14 commits into from

Conversation

louis-bompart
Copy link

@louis-bompart louis-bompart commented Nov 15, 2022

Fixes #2255

Changes

  • BREAKING: Remove support for Node 12 (and all the code relative to it)
  • Add support for Node 18
  • Updated Node 16 version

Notes:

  • Uses https://github.com/louis-bompart/runner_L0/ for the fixtures. Some changes were required (updates of dependencies+ node bump 12 to 18).
    I recommend moving the fixtures in this repo: this will allow public contributors to have a one-stop shop (or just to clone another branch, and not a whole other repo).
  • Didn't manually test. Relied 💯 on CI. See run

@@ -4,8 +4,10 @@ PRECACHE=$2

NODE_URL=https://nodejs.org/dist
UNOFFICIAL_NODE_URL=https://unofficial-builds.nodejs.org/download/release
NODE12_VERSION="12.22.7"
NODE16_VERSION="16.13.0"
# https://github.com/nodejs/build/issues/2540
Copy link
Author

@louis-bompart louis-bompart Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To monitor: nodejs/build#3077
Win-arm64 official NodeJS build should be discussed in this meeting/issue

Copy link

@sxa sxa Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI We're working towards it in nodejs/build#3046 but as always with a new platform it's dependent on people and systems to be able to elevate it to an official release, so for now pulling from the unofficial builds repo is the only way to get a versioned download from the nodejs project.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads-up @sxa , I somehow missed this one while digging up 😅

acquireExternalTool "$NODE_URL/v${NODE16_VERSION}/node-v${NODE16_VERSION}-linux-x64.tar.gz" node16 fix_nested_dir
acquireExternalTool "https://vstsagenttools.blob.core.windows.net/tools/nodejs/${NODE16_VERSION}/alpine/x64/node-v${NODE16_VERSION}-alpine-x64.tar.gz" node16_alpine
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so. I didn't find the version I needed in vstsagenttools.blob.core.windows.net
So I just replaced it with the good ol' build from bona fide NodeJS.

@fhammerl fhammerl closed this Nov 30, 2022
@remal
Copy link

remal commented Apr 19, 2023

@fhammerl, what's the plan for having Node 18? Can we have node18 runtime for GitHub actions?

@fhammerl
Copy link
Contributor

@remal With Node16 security updates coming to an end this October, we're of course planning on embedding a new Node.js version, but I can't give an exact date as of today.

@MikeMcC399
Copy link

@fhammerl

With Node16 security updates coming to an end this October, we're of course planning on embedding a new Node.js version, but I can't give an exact date as of today.

Perhaps you could answer into https://github.com/orgs/community/discussions/53217 when your plans are more concrete? Especially as this here is a closed PR and enhancement requests are specifically pointed to the discussion groups according to the issues template.

Node.js Release Schedule states Sep 11, 2023 as end-of-life transition for Node.js 16, which is earlier than the October date which you mentioned.

@TomasHubelbauer
Copy link

I'd be very grateful for more engagement in open community discussions as at the moment for people interested in this update, there are two closed issues with maintainer activity one has to discover and subscribe to themselves (this and #2255) whereas the open and officially recommended discussion forum sees no maintainer activity and information shared there is dug for these closed threads.

It works when one puts effort into discovering this information but it feels like things should flow the opposite direction. Just a friendly request though, at the end of the day I am happy with any information we get regardless where it comes from 🙏

@kroese
Copy link

kroese commented May 24, 2023

I created an issue ( #2619 ) about this, because this is taking way too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update supported Node versions for JavaScript Composite Actions
7 participants