Regression in polymorphic associations in ActiveRecord 5.2

[rzane]

This issue only affects Active Record 5.2.

In Active Record < 5.2, polymorphic joins will include a condition on the _type column.

LEFT OUTER JOIN "people"
ON "people"."id" = "notes"."notable_id" AND "notes"."notable_type" = 'Person'

In Active Record 5.2, the condition will not be included:

LEFT OUTER JOIN "people"
ON "people"."id" = "notes"."notable_id"

---

I created an issue on the polyamorous repo, but I figured more users are likely to see the issue here.

Sorry for the noise, here's the original issue: activerecord-hackery/polyamorous#37

[scarroll32]

No problem re: noise. Is it possible to create some failing tests on a branch?

[rzane]

Sure, I'll see if I can come up with a reproduction case through the Ransack API. I use polyamorous for baby_squeel, and that's where I noticed the issue. Though, I'm pretty sure I was able to reproduce using ransack.

[dholdren]

I ran into this issue as well. I'm using ransack 2.1.1 which now includes the polyamorous code

[gregmolnar]

@rzane Can you verify that this PR fixes your issue? #1004

[scarroll32]

Closed due to inactivity.