Set new error to replace ArgumentError #1478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was updated to raise InvalidSearchError on searching and sorting instead of ArgumentError
It was updated to ensure Ransack is raising InvalidSearchError when calling ransack! method
This error handling is an important configuration and need to have more atention
zokaibr
changed the title
|
@moretoend this looks great but it is blocked by a CI problem #1489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a proposal of removing ArgumentError raising on Search and Sorting and replace it by a custom error Ransack::InvalidSearchError as issued on #1460.
As of now, the exception Ransack::InvalidSearchError is inheriting from ArgumentError to enable a backward compatibility avoiding breaking changes in a minor version and a deprecation message for using ArgumentError were added. In a future version, it is expected to replace this inheritance from ArgumentError to StandardError.
The docs were also updated and there is a proposal of moving Error Handling to Getting Started area as it is an important configuration to be set.