Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using js-cookie@^3.1 instead of js-cookie@^2.2.0 #74

Open
lotfe-obaid opened this issue Apr 5, 2023 · 3 comments
Open

using js-cookie@^3.1 instead of js-cookie@^2.2.0 #74

lotfe-obaid opened this issue Apr 5, 2023 · 3 comments

Comments

@lotfe-obaid
Copy link

lotfe-obaid commented Apr 5, 2023

In our app we use js-cookie@^3.1, and when i tried to down grade to version 2.2, my app doesn't function correctly.
so i want to keep using js-cookie@^3.1
i fixed this by:
In gems/abraham-2.5.1/app/assets/javascripts/abraham/index.js i changed
//= require js-cookie/src/js.cookie
to:
//= require js-cookie/dist/js.cookie

js-cookie/dist/js.cookie is the default path for version 3.1
i would like to ask , is there a way to do that without modifying the gem?

@oclef
Copy link

oclef commented Apr 5, 2023

see my solution to issue

#69

It should work for you

@lotfe-obaid
Copy link
Author

lotfe-obaid commented Apr 5, 2023

is already working, but i want to keep the gem as it is without modifying anything, i would like to know if there is a way to override the path
//= require js-cookie/src/js.cookie
to:
//= require js-cookie/dist/js.cookie
from outside the gem

update: i saw this reply but i am looking for a better solution
#31 (comment)

@lotfe-obaid
Copy link
Author

lotfe-obaid commented Apr 9, 2023

@jabbett it would be appreciated if you could upgrade js-cookies to any newer version with the newer path js-cookie/dist/js.cookie this is our major compatibility issue which forces us to modify on the gem.
i have created a pull request #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants