Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies from node modules to assets #78

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

aashishpsaini
Copy link
Contributor

@aashishpsaini aashishpsaini commented Oct 25, 2023

This PR serves two things:

  • It moves the JS dependencies from node modules to assets

  • Removes webdrivers gem (as it's not a required gem) and adds chromedriver in test workflow

  • The code follows the Activate Care development guidelines.

  • There are appropriate tests, preferring unit tests to system tests.

  • Performance related impacts have been considered.

  • Commit messages follow our conventions.

  • If there is a migration needed, I have performed a staging migration test and updated development.sql.

@actmd actmd deleted a comment from aashishpsaini Oct 26, 2023
@canderson-activatecare
Copy link
Collaborator

canderson-activatecare commented Oct 26, 2023

@canderson-activatecare
Copy link
Collaborator

Closing and re-opening to apply proper checks.

Copy link
Collaborator

@canderson-activatecare canderson-activatecare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we'll capture Ruby upgrade in future issue so that we can rely on selenium chromedriver support. For now will need to have chromedriver as a system resource.

@canderson-activatecare canderson-activatecare changed the base branch from master to develop October 26, 2023 14:37
@canderson-activatecare canderson-activatecare dismissed their stale review October 26, 2023 14:37

The base branch was changed.

@canderson-activatecare
Copy link
Collaborator

@imreACTmd bypassing merge block due to target branch not having PRCHECKLIST config.

@canderson-activatecare canderson-activatecare merged commit 2f049a1 into develop Oct 26, 2023
3 checks passed
@canderson-activatecare canderson-activatecare deleted the feature/move-dependencies-to-assets branch October 26, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants