-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dependencies from node modules to assets #78
Move dependencies from node modules to assets #78
Conversation
|
Closing and re-opening to apply proper checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we'll capture Ruby upgrade in future issue so that we can rely on selenium chromedriver support. For now will need to have chromedriver as a system resource.
The base branch was changed.
@imreACTmd bypassing merge block due to target branch not having PRCHECKLIST config. |
This PR serves two things:
It moves the JS dependencies from node modules to assets
Removes
webdrivers
gem (as it's not a required gem) and adds chromedriver in test workflowThe code follows the Activate Care development guidelines.
There are appropriate tests, preferring unit tests to system tests.
Performance related impacts have been considered.
Commit messages follow our conventions.
If there is a migration needed, I have performed a staging migration test and updated development.sql.