-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Redux Toolkit Migration] queriesSlice #4016
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
9f560a7
to
ed63667
Compare
6c0c9ff
to
23fbbd0
Compare
373fa93
to
a18db77
Compare
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
a18db77
to
0a7e38c
Compare
e8d550e
to
ace372d
Compare
0a7e38c
to
9931e3e
Compare
8d4efb2
to
7c128b1
Compare
330129d
to
d332b25
Compare
432ab92
to
5ed4eb0
Compare
1433260
to
e1b59ad
Compare
f498538
to
968172c
Compare
e1b59ad
to
7c3dcba
Compare
968172c
to
377e06a
Compare
…y list redux state
36b6420
to
96c781d
Compare
actions/account.ts
/reducers/account.ts
->accounts/accountsSlice.ts
[Redux Toolkit Migration] accountsSlice #4012actions/queries.ts
/reducers/queries.ts
->queries/queriesSlice.ts
[Redux Toolkit Migration] queriesSlice #4016actions/app.ts
/reducers/app.ts
->app/appSlice.ts
actions/budgets.ts
/reducers/budgets.ts
->budgets/budgetsSlice.ts
actions/modals.ts
/reducers/modals.ts
->modals/modalsSlice.ts
actions/notifications.ts
/reducers/notifications.ts
->notifications/notificationsSlice.ts
actions/prefs.ts
/reducers/prefs.ts
->prefs/prefsSlice.ts
actions/user.ts
/reducers/user.ts
->users/usersSlice.ts
Reviewers - summary of changes on these Redux Toolkit Migration PRs:
loot-core/client/actions/queries.ts
andloot-core/client/reducers/queries.ts
desktop-client/queries/queriesSlice
loot-core/client/actions
todesktop-client/queries/queriesSlice
.unwrap()
ondispatch(...)
invocations which depend on the result of the dispatch e.g.const payees: PayeeEntity[] = await dispatch(getPayees())
-->const payees: PayeeEntity[] = await dispatch(getPayees()).unwrap()