Sort barchart data #4072

matt-fidd · 2025-01-02T16:35:58Z

Before:

After:

netlify · 2025-01-02T16:36:17Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`8ae64d1`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6776c5d68f95420008a583de
😎 Deploy Preview	https://deploy-preview-4072.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-01-02T16:37:13Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.64 MB → 5.64 MB (+211 B)	+0.00%

Changeset

File	Δ	Size
`src/components/reports/graphs/BarGraph.tsx`	📈 +211 B (+2.33%)	8.86 kB → 9.06 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.58 MB → 1.58 MB (+211 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	10.24 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/useAccountPreviewTransactions.js	1.63 kB	0%
static/js/narrow.js	83.36 kB	0%
static/js/wide.js	104.11 kB	0%
static/js/index.js	3.71 MB	0%

github-actions · 2025-01-02T16:37:14Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

matt-fidd · 2025-01-02T16:44:09Z

/update-vrt

coderabbitai · 2025-01-02T16:55:15Z

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eslint-plugin".

(The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eslint-plugin@latest --save-dev

The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request introduces a sorting mechanism in the BarGraph component of the desktop client application. It utilizes the useMemo hook to create a memoized version of the data sorted in ascending order based on the balanceTypeOp property. The unsorted data is sourced from the data[splitData] array, and this sorted data is then used in the data prop of the BarChart component. A comment has been added to clarify the purpose of the sorting functionality. The overall structure and logic of the BarGraph component remain unchanged, with the primary modification being the implementation of the sorting mechanism.

Possibly related PRs

✨ (dashboards) piecharts - sorting and label spacing #3855: The changes in this PR involve sorting data for the DonutGraph component, similar to the sorting mechanism introduced for the BarChart component in the main PR. Both PRs focus on enhancing data presentation through sorting.

Suggested labels

:sparkles: Merged

Suggested reviewers

MikesGlitch

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69b584a and 8ae64d1.

⛔ Files ignored due to path filters (10)

packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-3-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-3-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-3-chromium-linux.png is excluded by !**/*.png
upcoming-release-notes/4072.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be5bfa2 and 69b584a.

⛔ Files ignored due to path filters (10)

packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-labels-button-shows-the-labels-3-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-legend-button-shows-the-legend-side-bar-3-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-1-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-2-chromium-linux.png is excluded by !**/*.png
packages/desktop-client/e2e/reports.test.js-snapshots/Reports-custom-reports-Validates-that-show-summary-button-shows-the-summary-3-chromium-linux.png is excluded by !**/*.png
upcoming-release-notes/4072.md is excluded by !**/*.md

📒 Files selected for processing (1)

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (3 hunks)

🔇 Additional comments (2)

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (2)

2-2: Use of useMemo import looks good!

Great job importing useMemo; this is typically the correct approach for memoizing and optimizing computed values when data or configuration parameters change.

232-232: Confirm correctness of data prop usage.

Using data={sortedData} correctly applies the sorting changes to the chart. Once the sorting direction is fixed, confirm that the resulting bar chart displays data from largest to smallest as intended.

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx

youngcw · 2025-01-03T17:32:16Z

this is good for now, but it really would be nice to have options on how the sorting is done as part of creating the report.

matt-fidd · 2025-01-03T19:35:40Z

Agreed, I'll look at that in another PR and implement it across the board for all reports when I do.

matt-fidd · 2025-01-12T20:29:12Z

this is good for now, but it really would be nice to have options on how the sorting is done as part of creating the report.

#4141 :)

actual-github-bot bot changed the title ~~Sort barchart data from largest to smallest~~ [WIP] Sort barchart data from largest to smallest Jan 2, 2025

actual-github-bot bot added the 🚧 WIP label Jan 2, 2025

matt-fidd force-pushed the barchart-sorting branch 2 times, most recently from 9bc4cfb to 69b584a Compare January 2, 2025 16:51

matt-fidd changed the title ~~[WIP] Sort barchart data from largest to smallest~~ Sort barchart data from largest to smallest Jan 2, 2025

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jan 2, 2025

sort barchart data from largest to smallest

0882bdd

coderabbitai bot reviewed Jan 2, 2025

View reviewed changes

packages/desktop-client/src/components/reports/graphs/BarGraph.tsx Show resolved Hide resolved

matt-fidd changed the title ~~Sort barchart data from largest to smallest~~ Sort barchart data Jan 2, 2025

matt-fidd and others added 2 commits January 2, 2025 16:57

note

0e3c25b

Update VRT

8ae64d1

matt-fidd force-pushed the barchart-sorting branch from 69b584a to 8ae64d1 Compare January 2, 2025 16:59

youngcw approved these changes Jan 8, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jan 8, 2025

matt-fidd merged commit 6111f94 into actualbudget:master Jan 8, 2025
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Jan 8, 2025

matt-fidd deleted the barchart-sorting branch January 8, 2025 17:53

matt-fidd mentioned this pull request Jan 12, 2025

Fix barchart data sorting on barcharts split by interval #4137

Closed

coderabbitai bot mentioned this pull request Jan 12, 2025

Add sorting option to custom reports #4141

Merged

coderabbitai bot mentioned this pull request Jan 15, 2025

Fix inconsistent legend coloring in custom reports #4162

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort barchart data #4072

Sort barchart data #4072

matt-fidd commented Jan 2, 2025 •

edited

Loading

netlify bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

matt-fidd commented Jan 2, 2025

coderabbitai bot commented Jan 2, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

youngcw commented Jan 3, 2025

matt-fidd commented Jan 3, 2025

matt-fidd commented Jan 12, 2025

Sort barchart data #4072

Sort barchart data #4072

Conversation

matt-fidd commented Jan 2, 2025 • edited Loading

netlify bot commented Jan 2, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jan 2, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jan 2, 2025 • edited Loading

Bundle Stats — loot-core

matt-fidd commented Jan 2, 2025

coderabbitai bot commented Jan 2, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

youngcw commented Jan 3, 2025

matt-fidd commented Jan 3, 2025

matt-fidd commented Jan 12, 2025

matt-fidd commented Jan 2, 2025 •

edited

Loading

netlify bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

coderabbitai bot commented Jan 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)