Fix rounding of split rules #4190
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
jfdoming
changed the title
WalkthroughThe pull request introduces changes to the Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (1)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/loot-core/src/server/accounts/rules.test.ts (1)
680-709: LGTM! Comprehensive test coverage for remainder rounding.The test case effectively validates the rounding behavior for both negative and positive amounts, ensuring the remainder is correctly distributed to the last split transaction.
Consider adding a test case for an amount that divides evenly (e.g., 100 split into 50, 50) to verify that no adjustment is needed when remainder is 0. Example:
expect(rule.exec({ imported_payee: 'James', amount: 123 })).toMatchObject({ subtransactions: [{ amount: 62 }, { amount: 61 }], }); + +expect(rule.exec({ imported_payee: 'James', amount: 100 })).toMatchObject({ + subtransactions: [{ amount: 50 }, { amount: 50 }], +});
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4190.mdis excluded by!**/*.md
📒 Files selected for processing (2)
packages/loot-core/src/server/accounts/rules.test.ts(1 hunks)packages/loot-core/src/server/accounts/rules.ts(1 hunks)
🧰 Additional context used
📓 Learnings (2)
📓 Common learnings
Learnt from: jfdoming
PR: actualbudget/actual#3641
File: packages/loot-core/src/server/accounts/rules.ts:687-693
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In `packages/loot-core/src/server/accounts/rules.ts`, within the `execSplitActions` function, the zeroth index of `newTransactions` is reserved for actions that apply to all splits, so split transactions start from index 1.
packages/loot-core/src/server/accounts/rules.ts (1)
Learnt from: jfdoming
PR: actualbudget/actual#3641
File: packages/loot-core/src/server/accounts/rules.ts:687-693
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In `packages/loot-core/src/server/accounts/rules.ts`, within the `execSplitActions` function, the zeroth index of `newTransactions` is reserved for actions that apply to all splits, so split transactions start from index 1.
🔇 Additional comments (1)
packages/loot-core/src/server/accounts/rules.ts (1)
756-756: LGTM! Fix for split transaction rounding.The change correctly adjusts the last split transaction's amount by adding (instead of subtracting) the remainder. This ensures that split transactions sum up to the total amount. For example, when splitting $100 into three equal parts, it will now correctly distribute as 33, 33, 34 instead of 33, 33, 32.
The rounding adjustment was being applied the wrong way 😅 This PR fixes it and adds tests
Closes #3934