Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update soversion with each minor release #827

Open
lemire opened this issue Jan 5, 2025 · 0 comments
Open

update soversion with each minor release #827

lemire opened this issue Jan 5, 2025 · 0 comments

Comments

@lemire
Copy link
Member

lemire commented Jan 5, 2025

What is the problem this feature will solve?

Currently the ada library uses semantic versioning.
https://semver.org/

Screenshot 2025-01-05 at 2 06 40 PM

If you add functionality, without breaking the API, you usually issue a minor release, and this means that the version (major version) remains the same.

Semantic versioning is not compatible with Unix versioning because Unix requires that the compiled (possibly shared) library be interchangeable between versions.

What is the feature you are proposing to solve the problem?

Consider adding an soversion that gets incremented with each minor release (using the semantic convention).

Currently, the release script does not update the soversion. The soversion should get incremented with minor release. Currently, it does not get incremented at all unless there is a major release:

def update_cmakelists_version(new_version: str, file_path: str) -> None:

That is, currently the soversion is just the major semantic version, but that's not correct. All librairies with the same soversion must have the same exported functions with the same function signatures.

What alternatives have you considered?

I don't think that there is a sane alternative short of dropping the semantic versioning and adopting Unix versioning where each. That would mean making a major release the minute a new function is added.

@lemire lemire changed the title add soversion update soversion with each minor release Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant