Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select proper default for output_field based on distinct value #647

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

javiplx
Copy link

@javiplx javiplx commented Apr 26, 2020

Will return a set when distinct is enabled, and a list otherwise

Co-Authored-By: Adam Johnson <me@adamj.eu>
@javiplx
Copy link
Author

javiplx commented Apr 26, 2020

I believe that all functional tests succeed, but have no idea neither why the py38-multilint complains nor how to fix that particular error.

@adamchainz
Copy link
Owner

The error:

py38-codestyle run-test: commands[0] | multilint
Running black check
would reformat /home/runner/work/django-mysql/django-mysql/src/django_mysql/models/aggregates.py
Oh no! 💥 💔 💥
1 file would be reformatted, 90 files would be left unchanged.
black failed

Run black on the file to fix that.

@adamchainz
Copy link
Owner

So thinking about how we release this - it's a small breaking change. I think it will need a major version bump to communicate this, so I'd like to batch it with some other breaking changes I've not got around to making.

@adamchainz
Copy link
Owner

@javiplx It'll be faster if you run isort and black locally, rather than iterating against them on CI :) If you don't have python 3.8 locally, you should be able to run them with 3.6 or 3.7 just fine.

@javiplx
Copy link
Author

javiplx commented Apr 26, 2020

Finally !!!!
Regarding releasing, I agree with the mayor approach because this is not backwards compatible. In any case we'll make an internal release based on 3.2.0, because we're still running django 1.11

@javiplx javiplx force-pushed the feature/select_proper_output_field_for_groupconcat branch from b13f652 to ada23ea Compare June 1, 2020 17:48
Base automatically changed from master to main February 5, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants