New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/antlr #113

Merged

adarro merged 2 commits into adarro:master from truthencode:feature/antlr

Sep 23, 2023

Owner

adarro commented Sep 23, 2023

No description provided.

adarro added 2 commits

September 22, 2023 03:46


          :green-heart: checking permissions on todo

859790b


          🚧 scala library was not explicitly added in convention.

0e167f5

🎨 Format / lint

github-advanced-security bot found potential problems

View reviewed changes

...mmon/ddo-core/src/main/scala/io/truthencode/ddo/model/classes/LengendaryCharacterClass.scala

		@@ -0,0 +1,56 @@
		/*

Check notice

Code scanning / Scalastyle (reported by Codacy)

Header does not match expected text. Note

Header does not match expected text.

github-advanced-security bot found potential problems

View reviewed changes

...mmon/ddo-core/src/main/scala/io/truthencode/ddo/model/classes/LengendaryCharacterClass.scala

+               * Represents character's 30 to current level cap (32)
+               */
+              object LegendaryCharacterClass extends Enum[LegendaryCharacterClass] {
+                private val generateLevels = {

Check notice

Code scanning / Codacy-scalameta-pro (reported by Codacy)

Values should have minimum scope to avoid misuses. Note

generateLevels should have a smaller scope by using private[this]

github-advanced-security bot found potential problems

View reviewed changes

.swm/monster-manuals.2sgmr3sq.sw.md

+              app_version: 1.17.0
+              ---
+              Basic Monster Type information will be located in the io.truthencode.ddo.model.compendium package.

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 98 Warning

Expected: 80; Actual: 98

.swm/monster-manuals.2sgmr3sq.sw.md

+              | Monster Manual Entry | Type          | Race        | Sub-races |
+              | -------------------- | ------------- | ----------- | --------- |
+              | Elf                  | Elf           | Elf         | Drow Elf  |
+              | Purple Worm          | Magical Beast | Purple Worm | <br/>     |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Element: br Warning

Element: br

.swm/monster-manuals.2sgmr3sq.sw.md

+              | -------------------- | ------------- | ----------- | --------- |
+              | Elf                  | Elf           | Elf         | Drow Elf  |
+              | Purple Worm          | Magical Beast | Purple Worm | <br/>     |
+              | <br/>                | <br/>         | <br/>       | <br/>     |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Element: br Warning

Element: br

.swm/monster-manuals.2sgmr3sq.sw.md

+              | Purple Worm          | Magical Beast | Purple Worm | <br/>     |
+              | <br/>                | <br/>         | <br/>       | <br/>     |
+              <br/>

Check warning

Code scanning / Markdownlint (reported by Codacy)

Element: br Warning

Element: br

.swm/monster-manuals.2sgmr3sq.sw.md


		Ultimately, Entry, Type, Race and Sub-races should be applied. Although Monster Manual may not directly affect combat stats.

		<br/>

Check warning

Code scanning / Markdownlint (reported by Codacy)

Element: br Warning

Element: br

.swm/monster-manuals.2sgmr3sq.sw.md


		Basic Monster Type information will be located in the io.truthencode.ddo.model.compendium package.

		Ultimately, Entry, Type, Race and Sub-races should be applied. Although Monster Manual may not directly affect combat stats.

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 124 Warning

Expected: 80; Actual: 124

adarro merged commit 4e0d23b into adarro:master

15 of 17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet