Move ref and vert lines under whisker#48

adayim · Sep 30, 2023 · c885d30 · c885d30
1 parent 7215433
commit c885d30
Show file tree

Hide file tree

Showing 23 changed files with 34 additions and 30 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: forestploter
 Title: Create Flexible Forest Plot
-Version: 1.1.1
+Version: 1.1.2
 Authors@R: person(given="Alimu", 
                  family = "Dayimu",
                  email = "ad938@cam.ac.uk",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# forestploter 1.1.2
+
+* Draw reference line and other vertical lines under whiskers.
+
 # forestploter 1.1.1
 
 * Improved `ticks_digits` auto calculation.

diff --git a/R/forest.R b/R/forest.R
@@ -483,6 +483,8 @@ forest <- function(data,
                           t = 2,
                           l = j,
                           b = tot_row, r = j,
+                          # Make sure reference line is below the whisker
+                          z = max(gt$layout$z[grepl("core-", gt$layout$name)]),
                           clip = "off",
                           name = paste0("ref.line-", j))
 
@@ -504,6 +506,7 @@ forest <- function(data,
                             t = 2,
                             l = j,
                             b = tot_row, r = j,
+                            z = max(gt$layout$z[grepl("core-", gt$layout$name)]),
                             clip = "off",
                             name = paste0("vert.line-", j))
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -11,4 +11,4 @@ There were no ERRORs or WARNINGs.
 
 ---
 
-This version includes 1 bug fix and 6 improvement. 
+This version includes 1 bug fix improvement. 
diff --git a/tests/testthat/Rplots.pdf b/tests/testthat/Rplots.pdf
diff --git a/tests/testthat/_snaps/addgrob/add-grob-body.svg b/tests/testthat/_snaps/addgrob/add-grob-body.svg
diff --git a/tests/testthat/_snaps/addgrob/add-grob-header.svg b/tests/testthat/_snaps/addgrob/add-grob-header.svg
diff --git a/tests/testthat/_snaps/forest/arrow-end.svg b/tests/testthat/_snaps/forest/arrow-end.svg
diff --git a/tests/testthat/_snaps/forest/arrow-start.svg b/tests/testthat/_snaps/forest/arrow-start.svg
diff --git a/tests/testthat/_snaps/forest/different-sizes.svg b/tests/testthat/_snaps/forest/different-sizes.svg
diff --git a/tests/testthat/_snaps/forest/edit-plot-with-theme.svg b/tests/testthat/_snaps/forest/edit-plot-with-theme.svg
diff --git a/tests/testthat/_snaps/forest/insert-text-vector.svg b/tests/testthat/_snaps/forest/insert-text-vector.svg
diff --git a/tests/testthat/_snaps/forest/multiple-columns-and-multi-parameters.svg b/tests/testthat/_snaps/forest/multiple-columns-and-multi-parameters.svg
Original file line number	Diff line number	Diff line change
Expand Up		@@ -11,4 +11,4 @@ There were no ERRORs or WARNINGs.

		---

		This version includes 1 bug fix and 6 improvement.
		This version includes 1 bug fix improvement.