Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved link detection? #30

Open
dlxmax opened this issue Dec 23, 2017 · 2 comments
Open

Improved link detection? #30

dlxmax opened this issue Dec 23, 2017 · 2 comments

Comments

@dlxmax
Copy link

dlxmax commented Dec 23, 2017

The plugin fails to pick up the below link because the linked file isn't obviously a DOCX file, but the hypertext says that it is. This could be an easy fix and a huge extension of usability.

Troublesome code example:
(a href="/courses/1213543/assignments/7021324/submissions/8797434?download=57205833" class="file file-upload-submission-info__link")
Research Card(1).docx
(/a)

@dlxmax
Copy link
Author

dlxmax commented Apr 26, 2018

I really would be so pleased if you could implement this kind of detection. I use software that is supposed to render DOCX files in my browser, but when it fails--which is too often--the above code is what comes up instead. You really could make my day!

@zedred46
Copy link

zedred46 commented Mar 19, 2019

I would also really like this! I think the problem arises from the fact that the links like you describe aren't direct to file links, they redirect when clicked to the actual .docx file url. The extension just needs a way to pick up links with redirects, and display the icon to view the end file.

In the meantime I am using Office Editing for Docs, Sheets & Slides by Google (for which redirecting links work), but I'd much rather use Docs Online Viewer as I don't need to edit the files, and I don't want to mess them up by accident. I would also prefer the pdf-rendered style view of this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants