-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo support for commands #112
Conversation
thanks for the pull. should we also create corresponding issues for all the pulls? |
is it necessary to define the logo when executing a command? personally, I think the current implementation is sufficient. leaving the logo when calling the default command seems more normal to me. |
@dimtrovich As I mention in #115, currently, the logo doesn't show up for default commands, only for the built-in For example the logo showing in the screenshots I posted in #110 would not be possible without this PR as that is my default command I'm running help on. |
yea not super necessary but ok to have i guess as long as it doesn't mess up current working behavior or get on the way btw pull needs rebase again :D |
…em into help_item_even/odd
…em into help_item_even/odd
@kodie i think instead of fixing this conflict branch, it is easier to branch off new from the latest main and cherry-pick or hand-pick changes on top |
@adhocore I'll do that now and submit a new PR. |
Just like Application's logo function, Commands can have them now as well in the exact same way.
Fixes #115