GitHub Action Deploy GH Pages #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add workflow * add change to index for test * change build to production. * remove header * change node version * change install method to yarn
jwaspin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #701
Testing
This cannot be tested without merging this PR. In order to test this action, this PR must be merged and a new PR opened and merged to push these changes into the master branch. Merging a PR into the master branch is how this action can be tested.
That being said, I have tested this by forking to jwaspin/mdEditor and deploying to https://mdeditor.jwaspin.dev
CAUTION!! Once this PR has been merged, the current version of development needs to be tested and ready to be deployed before merging development into master (which should be the case anyway). This will cause all PRs merged into master to be deployed to production.
Changes
Automatically deploy mdEditor to gh-pages when merging to master. This action will build the production version of the application, deploy it, then create and tag a release version based on the version in package.json.
Current
Nothing happens when a branch is merged into master.
New
When a branch is merged into master, the new version of mdEditor will be deployed to gh-pages automatically from the new GitHub action added by this PR. After the app has been deployed to the production environment, the master branch will be tagged with the version number in package.json and it will be set as the latest release.
Breaking Changes
IMPORTANT
Not so much "breaking" but it's important to note that once this PR has been merged, all PRs merged into master will automatically be deployed to production.