Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ember internal Id as UUID for records, dictionaries, and dictionaries #685

Closed

Conversation

dvonanderson
Copy link
Contributor

Closing issues

closes #481

Pull Request

  • Please check if the PR fulfills these requirements

    • The commit message follows our guidelines
    • Tests for the changes have been added (for bug fixes / features)
      - [ ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • In this PR we introduce the use of the Ember Internal Ids as the source of tracking the record in the datastore as well as using it to uniquely identify a record, dictionary, or contact
  • What is the current behavior? (You can also link to an open issue here)
  • Current state of the app has the use of a package called UUID that generates unique Ids for records, dictionaries, and contacts, which doesn't allow us to validate Ids.
  • What is the new behavior (if this is a feature change)?
  • This PR will not fix existing mdJson datasets that have existing long UUID,

@dvonanderson dvonanderson added the enhancement Improve or modify an existing feature label Jun 4, 2024
@dvonanderson dvonanderson requested a review from hmaier-fws June 4, 2024 23:33
@dvonanderson dvonanderson self-assigned this Jun 4, 2024
@dvonanderson dvonanderson deleted the dvonanderson/feature/ember-record-identifiers branch July 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or modify an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign ember record identifiers ("id") based on UUID's
1 participant