Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handling of Ember Record Identifiers #690

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

dvonanderson
Copy link
Contributor

@dvonanderson dvonanderson commented Jul 27, 2024

Closing issues

closes #481

Pull Request

  • Please check if the PR fulfills these requirements

    • The commit message follows our guidelines
    • Tests for the changes have been added (for bug fixes / features)
      - [ ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • This is a feature update that introduces using the uuid for contacts, dictionaries, and records to become the Ember internal identifier.
  • This is the first step of validating existing records that may exist and now we can either update those records with new information or alarm the user of an existing record
  • Updated a few dependencies
  • Upgraded to use Yarn v4 for better package resolutions.
  • On any imported data sets that is not MdJson, we will now use the uuid identifier to create Ember internal identifiers.

@dvonanderson dvonanderson added discussion Issue for discussion by stakeholder group dependencies Pull requests that update a dependency file labels Jul 27, 2024
@dvonanderson dvonanderson requested a review from hmaier-fws July 27, 2024 14:29
@dvonanderson dvonanderson self-assigned this Jul 27, 2024
Copy link
Contributor

@hmaier-fws hmaier-fws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended

@hmaier-fws hmaier-fws merged commit 7f076e3 into develop Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file discussion Issue for discussion by stakeholder group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign ember record identifiers ("id") based on UUID's
2 participants