Fix embarrassing cut-and-paste bug in cffwrite library, used by 'tx' …

…and related tools. Caused first value in font FontBBox array to be set the same as the last value. Affects Type1 fonts processed by autohint and checkOutlines, as well as tx itself. Updated build numbers in FDK documents, as I hope to release a new public build next week.
adobe-type-tools · Jul 18, 2015 · 9232bc2 · 9232bc2
1 parent d3c5a35
commit 9232bc2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/FDK/AFDKO-Overview.html b/FDK/AFDKO-Overview.html
@@ -28,7 +28,7 @@ <h3 id="a_introduction">1. Introduction</h3>
 
   <p>Once the AFDKO is installed, all the command-line programs can be run by entering the command name in a Terminal window (OSX, Windows, Linux), along with the necessary option text. All command-line tools provide usage and help text with the options -u and -h. There is a separate user documentation file only for the makeotf tool. Using a command-line window may seem alarming if you are not used to it, but it is actually quite easy to learn a useful set of commands. Please read the FDK documentation "CommandLineHowTo.pdf", sub-titled "The Joys of Command Line", for pointers on how to get started.</p>
 
-  <h4>Current version 2.5 change number 64391, July 6 2015</h4>
+  <h4>Current version 2.5 change number 64655, July 17 2015</h4>
 
    <h4>Important Changes since 2.5 change number 63782, Mar 3 2015</h4>
   <ul>

diff --git a/FDK/FDKReleaseNotes.txt b/FDK/FDKReleaseNotes.txt
@@ -1,7 +1,7 @@
 FDKReleaseNotes.txt
 ===============================================================================
 
-FDK. v2.5 July 6 change number 64391.
+FDK. v2.5 July 17 change number 64655.
 
 FDK. 
 	autohint.
@@ -17,6 +17,7 @@ FDK.
 	makeotf. Fixed bug with Unicode values in the absolute path to to the font
 	home directory.
 	Add support for Character Variant (cvXX) feature params.
+	Fixed bug where setting Italic style forced OS/2 version to be 4.
 
 	spot. Added support for cvXX feature params. 
 	Fixed in crash in dumping long contextual substitution strings, such as in
@@ -31,7 +32,9 @@ FDK.
 	with CID > 32K. Fixed problem when font has 65536 glyphs: all glyphs after
 	first last would be excluded.
 	Fixed rounding errors in writing out decimal values to cff and t1 fonts
-
+	Increased interpreter stack depth to allow for CUBE operators (Library
+	elements) with up to 9 blend axes.
+
 	misc
 	Fixed windows builds: had to provide a roundf() function, and more includes for
 	the _tmpFile function. Fixed a few compile errors.

diff --git a/FDK/Read_Me_First.html b/FDK/Read_Me_First.html
@@ -5,7 +5,7 @@
     </head>
     <body>
 		<h1>ReadMe for the Adobe Font Development Kit for OpenType (AFDKO)</h1>
-		<h2>v2.5 change number 64391, July 6 2015</h2>
+		<h2>v2.5 change number 64655, July 17 2015</h2>
 		<p>
 			<h3>Contents</h3>
 			<ol>

diff --git a/FDK/Tools/Programs/public/lib/source/cffwrite/cffwrite_dict.c b/FDK/Tools/Programs/public/lib/source/cffwrite/cffwrite_dict.c
@@ -458,9 +458,9 @@ void cfwDictFillTop(cfwCtx g, DICT *dst,
 	    top->FontBBox[2] != 0 ||
 	    top->FontBBox[3] != 0) {
         top->FontBBox[0] = roundf(top->FontBBox[0]);
-        top->FontBBox[0] = roundf(top->FontBBox[1]);
-        top->FontBBox[0] = roundf(top->FontBBox[2]);
-        top->FontBBox[0] = roundf(top->FontBBox[3]);
+        top->FontBBox[1] = roundf(top->FontBBox[1]);
+        top->FontBBox[2] = roundf(top->FontBBox[2]);
+        top->FontBBox[3] = roundf(top->FontBBox[3]);
 		saveRealArrayOp(dst, 4, top->FontBBox, cff_FontBBox);
 	}