Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-14313 - Link to specific pages in PDF not working anymore #2542

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

cbogdan0707
Copy link
Contributor

@cbogdan0707 cbogdan0707 commented Jul 10, 2023

  • rfc allowed characters in fragment
Q                       A
Fixed Issues? SITES-14313
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided
Any Dependency Changes?
License Apache License, Version 2.0

@LSantha LSantha self-requested a review July 10, 2023 13:43
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2542 (238154f) into main (8e178c7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 238154f differs from pull request most recent head 7bc149c. Consider uploading reports for the commit 7bc149c to get more accurate results

@@             Coverage Diff              @@
##               main    #2542      +/-   ##
============================================
+ Coverage     87.19%   87.22%   +0.02%     
- Complexity     2614     2615       +1     
============================================
  Files           229      229              
  Lines          6958     6972      +14     
  Branches       1054     1054              
============================================
+ Hits           6067     6081      +14     
  Misses          358      358              
  Partials        533      533              
Impacted Files Coverage Δ
...cq/wcm/core/components/internal/link/LinkUtil.java 85.54% <100.00%> (+2.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cbogdan0707 cbogdan0707 merged commit 312e3d6 into main Jul 10, 2023
11 checks passed
@cbogdan0707 cbogdan0707 deleted the SITES-14313 branch July 10, 2023 14:09
@LSantha LSantha added this to the 2.23.2 milestone Jul 26, 2023
@LSantha LSantha changed the title SITES-14313: rfc allowed characters in fragment SITES-14313 - Link to specific pages in PDF not working anymore Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants