Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-14361 - List component added to template structure shows wrong images #2543

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

LSantha
Copy link
Contributor

@LSantha LSantha commented Jul 12, 2023

  • fixed featured image display for pages in a list
  • updated unit tests
Q                       A
Fixed Issues? SITES-14361
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes? No
License Apache License, Version 2.0

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2543 (5e1677b) into main (dd49da0) will increase coverage by 0.05%.
The diff coverage is 88.23%.

❗ Current head 5e1677b differs from pull request most recent head d3bf97f. Consider uploading reports for the commit d3bf97f to get more accurate results

@@             Coverage Diff              @@
##               main    #2543      +/-   ##
============================================
+ Coverage     87.22%   87.27%   +0.05%     
- Complexity     2616     2623       +7     
============================================
  Files           229      229              
  Lines          6974     6986      +12     
  Branches       1055     1060       +5     
============================================
+ Hits           6083     6097      +14     
  Misses          358      358              
+ Partials        533      531       -2     
Impacted Files Coverage Δ
...m/core/components/internal/models/v4/ListImpl.java 84.84% <50.00%> (+0.47%) ⬆️
...m/core/components/internal/models/v3/ListImpl.java 92.85% <88.88%> (+9.52%) ⬆️
...nts/internal/helper/image/AdaptiveImageHelper.java 90.00% <100.00%> (+0.20%) ⬆️
.../core/components/internal/models/v1/ImageImpl.java 89.15% <100.00%> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…images

 * fixed featured image display for pages in a list
 * updated unit tests
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cristianbrande cristianbrande merged commit ce27843 into main Jul 18, 2023
@cristianbrande cristianbrande deleted the SITES-14361 branch July 18, 2023 10:06
@LSantha LSantha added this to the 2.23.2 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants