Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-24155 - Content fragment list order by error #2842

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

LSantha
Copy link
Contributor

@LSantha LSantha commented Aug 28, 2024

  • added collator based sorting on the query for content fragments
  • extended unit tests
Q                       A
Fixed Issues? SITES-24155
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes? No
License Apache License, Version 2.0

 * added collator based sorting on the query for content fragments
 * extended unit tests
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.15%. Comparing base (37aee59) to head (88de997).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ls/v1/contentfragment/ContentFragmentListImpl.java 61.53% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2842      +/-   ##
============================================
- Coverage     87.19%   87.15%   -0.04%     
- Complexity     2691     2692       +1     
============================================
  Files           235      235              
  Lines          7176     7188      +12     
  Branches       1097     1100       +3     
============================================
+ Hits           6257     6265       +8     
- Misses          363      365       +2     
- Partials        556      558       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha LSantha requested review from YahorC and a team August 28, 2024 10:08
@LSantha LSantha merged commit 099ecbd into main Sep 3, 2024
14 checks passed
@LSantha LSantha deleted the SITES-24155 branch September 3, 2024 06:18
@LSantha LSantha added this to the 2.27.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants