SITES-24380 - Checkmarx Vulnerability - OOTB Search.js #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LSantha
commented
Sep 4, 2024
•
LSantha
commented
- protecting href in search component search.js against XSS
| Q | A |
|---|---|
| Fixed Issues? | SITES-24380 |
| Patch: Bug Fix? | Yes |
| Minor: New Feature? | |
| Major: Breaking Change? | No |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments and or markdown) |
| Any Dependency Changes? | No |
| License | Apache License, Version 2.0 |
* protecting href in search component search.js against XSS
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../src/content/jcr_root/apps/core/wcm/components/search/v1/search/clientlibs/site/js/search.js
Fixed
Show fixed
Hide fixed
.../src/content/jcr_root/apps/core/wcm/components/search/v2/search/clientlibs/site/js/search.js
Fixed
Show fixed
Hide fixed
* protecting href in search component search.js against XSS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2847 +/- ##
=========================================
Coverage 87.15% 87.15%
Complexity 2692 2692
=========================================
Files 235 235
Lines 7188 7188
Branches 1100 1100
=========================================
Hits 6265 6265
Misses 365 365
Partials 558 558 ☔ View full report in Codecov by Sentry. |
* protecting href in search component search.js against XSS
YahorC
approved these changes
Sep 5, 2024
* removed url encoding to avoid double encoding
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.