Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for parallel process not working on windows. #343

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2022

Parallel using ampersand is not supported on windows.
npm-run-all enables windows to run watch properly.

Description

Parallel processing using ampersands is not supported on Windows platform.
Therefore npm run watch fails to run properly on windows.

Related Issue

Motivation and Context

Following the WKND tutorial and running across this problem has hindered mine and my colleagues progress.
We came up with this solution.

How Has This Been Tested?

We tested it on Windows and Linux and it seems to perform as expected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Parallel using ampersand is not supported on windows.
npm-run-all enables windows to run watch properly.
@ghost
Copy link
Author

ghost commented May 16, 2022

I've signed Adobe open source CLA now.

@ghost ghost closed this May 16, 2022
@ghost ghost reopened this May 16, 2022
@godanny86
Copy link
Contributor

@prupra we tend to keep this project in sync with the AEM Project Archetype. Would you mind performing a PR into that project as well? https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/ui.frontend.general/package.json#L17

@ghost
Copy link
Author

ghost commented Jun 8, 2022

@prupra we tend to keep this project in sync with the AEM Project Archetype. Would you mind performing a PR into that project as well? https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/ui.frontend.general/package.json#L17

Sorry for the delay, I will implement this in archetype now.

@SachinMali
Copy link
Contributor

SachinMali commented Jan 10, 2023

@prupra The 'npm-run-all' needs the associated module, the PR on Archetype Project needs an update. Can you please review it.

Here is the PR, adobe/aem-project-archetype#1017

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants