Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FSI and Healthcare themes for Adaptive Form #1039

Merged
merged 9 commits into from
Jun 29, 2023

Conversation

pankaj-parashar
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@suryansh29
Copy link
Contributor

suryansh29 commented Feb 7, 2023

I can see back and cancel image in assets, they will not be localized.
src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-back.png
src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-cancel.png

and continue and submit in images as well
src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-continue.png
src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-theme2-submit.png

<jcr:content
cq:conf=""
jcr:lastModified="{Date}2022-09-01T18:48:10.103-07:00"
jcr:primaryType="dam:AssetContent"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only assets and renditions files are present in the theme, aren't there any other files in theme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AF1 theme. Theme definition is at /fsi/_jcr_content/renditions/theme-json/.content.xml When imported to the system, clientlibrary is generated by a listener.

@suryansh29
Copy link
Contributor

For Back and cancel I see PNG images, it will not be localized
src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-back.png

src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-cancel.png
@pankaj-parashar

@pankaj-parashar
Copy link
Contributor Author

For Back and cancel I see PNG images, it will not be localized src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-back.png

src/main/archetype/ui.content/src/main/content/jcr_root/content/dam/formsanddocuments-themes/appId/fsi/assets/mobile-cancel.png @pankaj-parashar

I see that these images rules are not effective for device renditions.

Copy link
Contributor

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rismehta rismehta merged commit 7cceeaf into adobe:develop Jun 29, 2023
@pankaj-parashar pankaj-parashar added this to the 43 milestone Jul 4, 2023
pankaj-parashar added a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
* Adding FSI and Healthcare themes

* Adding FSI and Healthcare themes
Adding author metadata

* Adding FSI and Healthcare themes for Adaptive Form
pankaj-parashar added a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
* Adding FSI and Healthcare themes

* Adding FSI and Healthcare themes
Adding author metadata

* Adding FSI and Healthcare themes for Adaptive Form
pankaj-parashar added a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
* Adding FSI and Healthcare themes

* Adding FSI and Healthcare themes
Adding author metadata

* Adding FSI and Healthcare themes for Adaptive Form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants