Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all the plugins in the bnd config properly instead of only the last one #1046

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dylan-reniers-digitalum

Description

Use separate properties for the different plugins in the BND tools config, so all plugins are properly loaded and not overwritten so only the last one is used.

Related Issue

Motivation and Context

Currently only the last plugin definition is used, since it overwrites any previous plugins in the config.

How Has This Been Tested?

Verified by doing maven builds and comparing the output of the OSGi manifest, to see which headers are present. Before only the Sling-Model-Classes header was present, now also the Sling-ContextAware-Configuration-Classes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant