Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-7599 forms spa #1058

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

FORMS-7599 forms spa #1058

wants to merge 7 commits into from

Conversation

barshat7
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

#if($isFormsSpa)
componentGroup="${appTitle} - Adaptive Form"/>
#else
componentGroup=".${appTitle} - Adaptive Form"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would expose form container in march release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we keep it hidden in current release? How will the customer use it?

@@ -26,6 +26,14 @@
"react-router": "^5.1.2",
"regenerator-runtime": "^0.13.7",
#end
#if ($isFormsSpa)
"@aemforms/af-core": "^0.22.37",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm with the PM team, if we should share sample for MUI here ?


// submit error handler
form.subscribe((action) => {
const defaultSubmissionError = 'Error during form submission'; // todo localize this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to add a small sample for localization here. Can you check with @amit-mnnit once ?

Copy link
Contributor

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants