Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-test: fix version of node lts #1094

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

AlexRRR
Copy link
Contributor

@AlexRRR AlexRRR commented Jun 23, 2023

Description

UI tests dockerfile was pointing to node-18 and the latest minor release broke the build. Fixing to the known version

Related Issue

CMGR-46019

How Has This Been Tested?

build locally the dockerfile with change

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@barshat7 barshat7 merged commit 6b6b293 into adobe:develop Jun 26, 2023
@pankaj-parashar pankaj-parashar added this to the 43 milestone Jul 4, 2023
pankaj-parashar pushed a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
pankaj-parashar pushed a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
pankaj-parashar pushed a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants