-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-9449 - Add first set of ootb core component AF templates to archetype #1095
Merged
pankaj-parashar
merged 3 commits into
adobe:develop
from
pankaj-parashar:ootb-templates
Jun 28, 2023
Merged
FORMS-9449 - Add first set of ootb core component AF templates to archetype #1095
pankaj-parashar
merged 3 commits into
adobe:develop
from
pankaj-parashar:ootb-templates
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding ootb templates with appId variables for resource paths Adding theme reference for cloud service and 6.5 Adding thumbnails Fixing header and footer policy Template policy issue condition fixed Fixing policy issue for benefits enrollment Fixing logo issue using DAM image Adding WKND logo filter entry Added author metadata Fixing top tab resource type
pankaj-parashar
changed the title
FORMS-9449 - Add first set of core component AF templates to archetype
FORMS-9449 - Add first set of ootb core component AF templates to archetype
Jun 26, 2023
Fixing rule issue.
rismehta
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pankaj-parashar
added a commit
to pankaj-parashar/aem-project-archetype
that referenced
this pull request
Jul 4, 2023
…hetype (adobe#1095) * FORMS-9449 - Add first set of core component AF templates to archetype Adding ootb templates with appId variables for resource paths Adding theme reference for cloud service and 6.5 Adding thumbnails Fixing header and footer policy Template policy issue condition fixed Fixing policy issue for benefits enrollment Fixing logo issue using DAM image Adding WKND logo filter entry Added author metadata Fixing top tab resource type Fixing rule issue. --------- Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
pankaj-parashar
added a commit
to pankaj-parashar/aem-project-archetype
that referenced
this pull request
Jul 4, 2023
…hetype (adobe#1095) * FORMS-9449 - Add first set of core component AF templates to archetype Adding ootb templates with appId variables for resource paths Adding theme reference for cloud service and 6.5 Adding thumbnails Fixing header and footer policy Template policy issue condition fixed Fixing policy issue for benefits enrollment Fixing logo issue using DAM image Adding WKND logo filter entry Added author metadata Fixing top tab resource type Fixing rule issue. --------- Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
pankaj-parashar
added a commit
to pankaj-parashar/aem-project-archetype
that referenced
this pull request
Jul 4, 2023
…hetype (adobe#1095) * FORMS-9449 - Add first set of core component AF templates to archetype Adding ootb templates with appId variables for resource paths Adding theme reference for cloud service and 6.5 Adding thumbnails Fixing header and footer policy Template policy issue condition fixed Fixing policy issue for benefits enrollment Fixing logo issue using DAM image Adding WKND logo filter entry Added author metadata Fixing top tab resource type Fixing rule issue. --------- Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following templates are added.
The following are the changes done.
Fixing top tab resource type
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: