Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FORMS-9995 Fixed issue: Image in template header not rendering in publish #1115

Merged
merged 2 commits into from
Aug 2, 2023
Merged

FORMS-9995 Fixed issue: Image in template header not rendering in publish #1115

merged 2 commits into from
Aug 2, 2023

Conversation

ravise5
Copy link
Contributor

@ravise5 ravise5 commented Aug 1, 2023

@review @rismehta

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ravise5 ravise5 requested a review from rismehta August 1, 2023 11:08
rismehta
rismehta approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This use-case is specific to forms, where one could upload an image inline as part of structure in an editable template

@ravise5 ravise5 merged commit e22ee77 into develop Aug 2, 2023
9 checks passed
@ravise5 ravise5 deleted the FORMS-9995 branch August 2, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rismehta rismehta rismehta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravise5 @rismehta