FORMS-9473: replaced parsys with container with responsive grid #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshat7
reviewed
Aug 22, 2023
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="wcm/core/components/policies/mapping"/> | ||
| jcr:title="Header" |
There was a problem hiding this comment.
do we really need title and layout in policies?
barshat7
reviewed
Aug 22, 2023
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="wcm/foundation/components/responsivegrid"> | ||
| jcr:title="Header" | ||
| sling:resourceType="wcm/foundation/components/responsivegrid" |
There was a problem hiding this comment.
I might be missing something here, but what is the change done here? The resourceType still seems to be the same. Only the tag name is changed rom parsys1 to container1, does this even make any difference? I believe its just a name
egmox
force-pushed
the
FORMS-9473-container_insteadOf_parsys
branch
from
57ac330
to
9d6eea3
Compare
barshat7
approved these changes
Sep 6, 2023
pankaj-parashar
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Container component should be replaced only for core component AF related artifacts.
- Blank AF v2 template
- AF Page V2 template type
Basic and Blank templates (Foundation AF component) shouldn't be changed.
cc : @sakshi-arora1
pankaj-parashar
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: