Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archetype React Components Added #1181

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Archetype React Components Added #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42b5b16
archetype react components added
rajatkhurana-adobe Apr 3, 2024
fee03e3
build fix
rajatkhurana-adobe Jun 12, 2024
114aaf7
build fix I
rajatkhurana-adobe Jun 14, 2024
59cdbbe
build fix II
rajatkhurana-adobe Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/archetype/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#set( $endbrace = "}" )
#set( $isSpaProject = $frontendModule == "angular" || $frontendModule == "react" || $frontendModule == "decoupled" )
#set( $includeClassifierOnUberJar = $aemVersion.matches("6\.5\.[0-5]") )
#set( $isFormsSpa = ($includeFormsenrollment == "y" || $includeFormscommunications == "y") && ($frontendModule == "react") )

<modelVersion>4.0.0</modelVersion>
<groupId>${groupId}</groupId>
Expand Down
7 changes: 6 additions & 1 deletion ...c/main/content/jcr_root/apps/__appId__/components/adaptiveForm/formcontainer/.content.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@
jcr:title="Form Container"
fd:version="2.1"
sling:resourceSuperType="core/fd/components/form/container/v2/container"
componentGroup="${appTitle} - Adaptive Form"/>
#if($isFormsSpa)
componentGroup="${appTitle} - Adaptive Form"
#else
componentGroup=".${appTitle} - Adaptive Form"
#end
/>
21 changes: 21 additions & 0 deletions src/main/archetype/ui.frontend.react/config-overrides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
const { override } = require('customize-cra');

module.exports = override(
Copy link
Contributor

@barshat7 barshat7 Apr 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only required for forms then we should have a check of isFormsSpa, or delete this file if isFormsSpa==false

(config) => {
// Enable the use of .babelrc
config.module.rules.push({
test: /\.m?js$/,
use: {
loader: 'babel-loader',
options: {
babelrc: true,
plugins: [
"@babel/plugin-proposal-optional-chaining",
"@babel/plugin-proposal-nullish-coalescing-operator"],
},
},
});

return config;
}
);
Loading
Loading