Skip to content

Commit

Permalink
fix(Accessibility): Drag and Drop feature is not keyboard accessible (#…
Browse files Browse the repository at this point in the history 
…346)

Co-authored-by: ens13533 <ens13533@adobe.com>
Co-authored-by: Michael Jordan <mijordan@adobe.com>
  • Loading branch information
@mariang-ens @majornista
3 people authored Jul 30, 2024
1 parent 3f510ef commit d762873
Show file tree
Hide file tree
Showing 11 changed files with 533 additions and 38 deletions.
4 changes: 3 additions & 1 deletion coral-component-dialog/src/tests/test.Dialog.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ describe('Dialog', function () {
clientX: x,
clientY: y,
bubbles: true,
cancelable: true
cancelable: true,
pointerType: 'mouse',
detail: 1
});
};

Expand Down
24 changes: 12 additions & 12 deletions coral-component-table/examples/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128" alt="thumbnail">
<img alt="" src="https://via.placeholder.com/128x128" alt="thumbnail">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -197,7 +197,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand All @@ -208,7 +208,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Alpha</td>
<td is="coral-table-cell">January 28, 2012</td>
Expand All @@ -219,7 +219,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Beta</td>
<td is="coral-table-cell">December 1, 2011</td>
Expand All @@ -230,7 +230,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<coral-checkbox></coral-checkbox>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -240,7 +240,7 @@ <h2 class="coral--Heading--S">Checkbox selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand Down Expand Up @@ -289,7 +289,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128" alt="thumbnail">
<img alt="" src="https://via.placeholder.com/128x128" alt="thumbnail">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -299,7 +299,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand All @@ -309,7 +309,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Alpha</td>
<td is="coral-table-cell">January 28, 2012</td>
Expand All @@ -319,7 +319,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Beta</td>
<td is="coral-table-cell">December 1, 2011</td>
Expand All @@ -329,7 +329,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Charlie</td>
<td is="coral-table-cell">February 15, 2012</td>
Expand All @@ -339,7 +339,7 @@ <h2 class="coral--Heading--S">ListView selection</h2>
</tr>
<tr is="coral-table-row">
<td is="coral-table-cell" coral-table-rowselect>
<img alt="" src="http://via.placeholder.com/128x128">
<img alt="" src="https://via.placeholder.com/128x128">
</td>
<td is="coral-table-cell" role="rowheader">Delta</td>
<td is="coral-table-cell">May 16, 2012</td>
Expand Down
4 changes: 3 additions & 1 deletion coral-component-table/i18n/translations.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ export default {
"sorted by column {0}, in ascending order": "sorted by column {0} in ascending order",
"sorted by column {0}, in descending order": "sorted by column {0} in descending order",
", checked": ", checked",
", unchecked": ", unchecked"
", unchecked": ", unchecked",
"reordering": "reordering",
"reordered to row {0}": "reordered to row {0}",
},
"de-DE": {
"Select": "Auswählen",
Expand Down
Loading

0 comments on commit d762873

Please sign in to comment.