Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add button role to table header interactive element #289

Merged
merged 11 commits into from
Dec 13, 2023
Merged

fix: Add button role to table header interactive element #289

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eb54f2b
added role button to the table header interactive elements
StoianLucian Apr 10, 2023
97a958d
Merge branch 'adobe:master' into SITES-10962-1
StoianLucian Apr 24, 2023
a99af30
moved setting the button role to not be triggered only when the colum…
StoianLucian Apr 24, 2023
2721ff3
Merge branch 'master' into SITES-10962-1
StoianLucian May 18, 2023
3fecd81
Merge branch 'adobe:master' into SITES-10962-1
StoianLucian May 31, 2023
929e4aa
moved the functionality in order to apply the role button when the pa…
StoianLucian Jun 6, 2023
037b03f
Merge branch 'SITES-10962-1' of https://github.com/StoianLucian/coral…
StoianLucian Jun 6, 2023
737d397
removed console log
StoianLucian Jun 6, 2023
dbe70d0
removed white space
StoianLucian Jun 6, 2023
7d2909a
implemented the same changes as done for coralui3
StoianLucian Jun 14, 2023
c5556e5
resolved comment
StoianLucian Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions coral-component-table/src/scripts/Table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,6 +2467,10 @@ const Table = Decorator(class extends BaseComponent(HTMLTableElement) {
headerCell.setAttribute('role', 'rowheader');
}
headerCell.setAttribute('scope', scope);

if(headerCell.hasAttribute('sortable')){
headerCell.content.setAttribute('role', 'button');
}
}

/** @private */
Expand Down
Loading