Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add coral tabs item background color #315

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

RazvanPRA
Copy link
Contributor

@RazvanPRA RazvanPRA commented Aug 29, 2023

https://jira.corp.adobe.com/browse/SITES-10906

In this PR I added a new variable that contains the right color for the background so that the issue mentioned in the ticket will not be reproduced.
In the PR mentioned below you can see the difference in the images:
https://git.corp.adobe.com/Granite/com.adobe.granite.ui.coral-spectrum/pull/167

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Pareesh Pareesh changed the title SITES-10906 State of active component lacks 3 to 1 contrast ratio fix: Add coral tabs item background color Oct 31, 2023
@Pareesh Pareesh merged commit a4806a1 into adobe:master Oct 31, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
## [4.15.26](v4.15.25...v4.15.26) (2023-10-31)

### Bug Fixes

* Add coral tabs item background color([#315](#315)) ([a4806a1](a4806a1))
Copy link

🎉 This PR is included in version 4.15.26 🎉

The release is available on:

Your semantic-release bot 📦🚀

@StoianLucian StoianLucian deleted the SITES-10906 branch April 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants