Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the aria-label to color value for color input #316

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

RazvanPRA
Copy link
Contributor

@RazvanPRA RazvanPRA commented Sep 7, 2023

https://jira.corp.adobe.com/browse/SITES-10925

I added the aria-label to fix the issue:

6 6

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Copy link

@petcud petcud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the curly braces reports please.

@ens84646
Copy link
Contributor

ens84646 commented Nov 9, 2023

fix the curly braces reports please.

@petcud check warnings not related to the actual change, should we resolve this reports for every PR created as long as it were not generated by this PR?

@Pareesh Pareesh changed the title SITES-10925 Form element does not have a label fix: Set the aria-label to color value for color input Dec 13, 2023
@Pareesh Pareesh merged commit eab60b0 into adobe:master Dec 13, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
## [4.15.27](v4.15.26...v4.15.27) (2023-12-13)

### Bug Fixes

* Add button role to table header interactive element ([#289](#289)) ([7384f9f](7384f9f))
* Coral shell help items should have list role ([#321](#321)) ([5c631fd](5c631fd))
* Correct anchor color and table header text color ([#317](#317)) ([19c2665](19c2665))
* Ensure interactive controls are not nested. ([#324](#324)) ([ef230a4](ef230a4))
* Set the aria-label to color value for color input  ([#316](#316)) ([eab60b0](eab60b0))
Copy link

🎉 This PR is included in version 4.15.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants