fix: Correct anchor color and header text color #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ens84646
approved these changes
Sep 14, 2023
StoianLucian
approved these changes
Sep 27, 2023
@petcud check warnings not related to the actual change, should we resolve this reports for every PR created as long as it were not generated by this PR? |
Pareesh
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
## [4.15.27](v4.15.26...v4.15.27) (2023-12-13) ### Bug Fixes * Add button role to table header interactive element ([#289](#289)) ([7384f9f](7384f9f)) * Coral shell help items should have list role ([#321](#321)) ([5c631fd](5c631fd)) * Correct anchor color and table header text color ([#317](#317)) ([19c2665](19c2665)) * Ensure interactive controls are not nested. ([#324](#324)) ([ef230a4](ef230a4)) * Set the aria-label to color value for color input ([#316](#316)) ([eab60b0](eab60b0))
|
🎉 This PR is included in version 4.15.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/SITES-10935
With these color changes, I adjusted the contrast, which can be seen in the images below (the contrast must be at least 3:1)
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: