Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SITES-2874 Accessibility) - Visual list is not marked up as list. #320

Closed
wants to merge 14 commits into from

Conversation

StoianLucian
Copy link
Contributor

Ticket: SITES-2874

Added role list and listitem to the required elements

@StoianLucian
Copy link
Contributor Author

StoianLucian commented Oct 26, 2023

after applying the change, axe devTools can't identify the problem that appears in the failing build

image (1)

@StoianLucian
Copy link
Contributor Author

Capture

Copy link

@petcud petcud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the curly braces.
For the complexity warning, if you cannot simplify the complexity, and it's code that wasn't introduced by you, it might generate a code smell report but should be fine to merge.

Copy link

@petcud petcud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try the aria role 'list' instead of the 'listitem'

@ens84646
Copy link
Contributor

ens84646 commented Nov 9, 2023

Please fix the curly braces. For the complexity warning, if you cannot simplify the complexity, and it's code that wasn't introduced by you, it might generate a code smell report but should be fine to merge.

@petcud check warnings not related to the actual change, should we resolve this reports for every PR created as long as it were not generated by this PR?

@StoianLucian
Copy link
Contributor Author

Hi @petcud the role "list" is only to be use for the wrapper of the list and the role "listitem" is to be used for the each element from inside the wrapper as suggested in the ticket and in the accessibility guides https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listitem_role

@StoianLucian StoianLucian changed the title SITES-2874 Accessibility - Visual list is not marked up as list. fix(SITES-2874 Accessibility) - Visual list is not marked up as list. Mar 18, 2024
@StoianLucian
Copy link
Contributor Author

@Pareesh is there anything else we should do regarding this ticket? If not could you merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants